Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IN-12B Nixie Tubes #7

Merged
merged 3 commits into from
Dec 25, 2024
Merged

Add IN-12B Nixie Tubes #7

merged 3 commits into from
Dec 25, 2024

Conversation

dbrgn
Copy link
Collaborator

@dbrgn dbrgn commented Dec 23, 2024

SUMMARY

Add IN-12B Nixie Tubes.

image

Note: Initially I was confused about the relation between Sovtek and Reflektor. According to ChatGPT (I plausibilized the statement), Sovtek is the brand and Reflektor is the production plant (owned by the USSR).

screenshot-20241223-013235

DATASHEETS / REFERENCES
OPEN QUESTIONS / UNRESOLVED ISSUES

n/a

CHECKLIST
  • I have read and followed the library conventions¹.
  • For packages, I followed IPC7351C (see details in library conventions).
  • For modified elements, I bumped their version number².
  • I already used the new library elements in a design and verified their correctness (optional).
  • I'm the copyright owner of the added content (i.e. the changes are made by myself, not copied/imported from somewhere else).
  • I agree to publish all my changes under the CC0 Public Domain License³, allowing everyone to use and modify the content without any restrictions.

¹ Library Conventions: https://docs.librepcb.org/#libraryconventions
² Minor version bump if only metadata was modified (e.g. "0.1" -> "0.1.1"), major version bump if functional changes were made (e.g. "0.1" -> "0.2")
³ CC0 Public Domain License: https://en.wikipedia.org/wiki/CC0

@dbrgn dbrgn added the addition New library element. label Dec 23, 2024
@dbrgn dbrgn requested a review from ubruhin December 23, 2024 00:39
Copy link
Contributor

@ubruhin ubruhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theoretically the documentation polygon is missing and the legend polygon should be outside the package outline (currently both polygons are identical):

image

But since it's more a "fun" package anyway, feel free to merge as-is 😉

pkg/d06de9dc-d4ab-4de4-ac44-b544e4ff80bb/package.lp Outdated Show resolved Hide resolved
@dbrgn
Copy link
Collaborator Author

dbrgn commented Dec 24, 2024

Theoretically the documentation polygon is missing

Oops, you're right!

and the legend polygon should be outside the package outline (currently both polygons are identical):

I originally kept them like that because every tube has slightly different dimensions, so it won't be exact anyways. But since I edited the outlines to add the documentation layer, I also fixed that one.

@dbrgn dbrgn requested a review from ubruhin December 24, 2024 22:07
@dbrgn dbrgn merged commit 4dd9f35 into master Dec 25, 2024
2 checks passed
@dbrgn dbrgn deleted the in-12b branch December 25, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition New library element.
Development

Successfully merging this pull request may close these issues.

2 participants