Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sym/cmp for coax/triax connectors #18

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

eto-
Copy link
Contributor

@eto- eto- commented Oct 25, 2023

SUMMARY

Added spacers category (should go in base?).
Added symbols and components for spacers and coax/triax conectors

DATASHEETS / REFERENCES
OPEN QUESTIONS / UNRESOLVED ISSUES

Spacers cat should go in base?

CHECKLIST
  • I have read and followed the library conventions¹.
  • For packages, I followed IPC7351C (see details in library conventions).
  • For modified elements, I bumped their version number².
  • I already used the new library elements in a design and verified their correctness (optional).
  • I'm the copyright owner of the added content (i.e. the changes are made by myself, not copied/imported from somewhere else).
  • I agree to publish all my changes under the CC0 Public Domain License³, allowing everyone to use and modify the content without any restrictions.

¹ Library Conventions: https://docs.librepcb.org/#libraryconventions
² Minor version bump if only metadata was modified (e.g. "0.1" -> "0.1.1"), major version bump if functional changes were made (e.g. "0.1" -> "0.2")
³ CC0 Public Domain License: https://en.wikipedia.org/wiki/CC0

Alessandro Razeto and others added 3 commits October 25, 2023 11:17
- Add keywords
- Move symbol texts
- Rename pins 1,2,3 to SHIELD,1,2
- Change component prefix CN -> J
- Hide pin names
@ubruhin ubruhin self-assigned this Sep 19, 2024
@ubruhin ubruhin added addition New library element. ready for review Waiting for review by maintainers. labels Sep 19, 2024
@ubruhin ubruhin changed the title Added spacers and coax/triax connectors Add sym/cmp for coax/triax connectors Sep 19, 2024
@ubruhin
Copy link
Contributor

ubruhin commented Sep 19, 2024

I'm not sure about the spacer - it seems to have an electrical signal, but I'd expect spacers to have no electrical function. Also categories should go to the base library. For now, I just removed them to get this PR ready.

The connectors look nice, I just added a few minor changes. I also renamed the component signals and prefix (don't know where the terms "C", "H", "G" and "CN" come from, please let me know if there's a reason to keep these names).

@ubruhin ubruhin merged commit c79b7ef into LibrePCB-Libraries:master Sep 19, 2024
1 check passed
@eto-
Copy link
Contributor Author

eto- commented Sep 19, 2024

Spacers are both a mechanical tool and an electronic connection.
When you have board with mezzanines the ground is typically delivered by these conductive spacers.
The spacers can be implemented with screws or with specific SMD components. Just as an example the M.2 standard (used by SSD and in IoT for micromod) uses SMD spacers.
Since LibrePCB generates the 3D modeling the spacers will be useful, therefore the need for the symbol.

For the triax the previous name were C = cold, H = hot, G = guard. The other standard is Force, Shield and Guard.

@ubruhin
Copy link
Contributor

ubruhin commented Sep 20, 2024

The spacers can be implemented with screws or with specific SMD components. Just as an example the M.2 standard (used by SSD and in IoT for micromod) uses SMD spacers.

Ah now I understand what you mean. It seems on Digikey they are called "standoff". Anyway, I'd say that should go to the base library, not connectors. And I'd try to draw a more expressive symbol (maybe check first how it is drawn in other EDA tool libraries). And no new category is needed, there's already "Electromechanical -> Board Spacers".

For the triax the previous name were C = cold, H = hot, G = guard. The other standard is Force, Shield and Guard.

Oops good to know, seems I was a bit too fast with merging 🤦 Renamed it to Force/Guard/Shield in 58e0a55.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition New library element. ready for review Waiting for review by maintainers.
Development

Successfully merging this pull request may close these issues.

2 participants