Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multi-site admin functionality #1640

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maggienegm
Copy link
Contributor

Added an admin.php file to handle multiple sites and their respective setup and configuration. You have to manually type the URL to access admin.php, which requires user authentication before its contents are accessed. Currently, it includes the following functionalities:

  • Upgrade Database (setup/sql_upgrade.php)
  • Access Control Upgrade (acl_upgrade.php)
  • Patch Database (sql_patch.php)

This will help prevent unauthenticated info disclosure and unauthenticated admin actions.

Context: PR 1638

Copy link
Contributor

@aethelwulffe aethelwulffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to check out the paradigm that the site "default" is never actually used for a clinic. Among other things, it really helps when a running install is also a repo, so the local DB/site files can always have a .gitignore to keep them untracked, while the base code gets updated...and PR's/branches can come straight off the running code, or test new code too.

@maggienegm
Copy link
Contributor Author

Hmmm, I thought "default" was just a value; "default" is a site ID name and is the default value when creating a site using setup.php.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants