Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Old Metric vitals Form #1629

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Disable Old Metric vitals Form #1629

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4bc27dc
Diable Old Metric vitals Form
ahanipeitra1994 Jul 22, 2020
17d69cc
u
ahanipeitra1994 Aug 12, 2020
e2bdbed
comment removed
ahanipeitra1994 Aug 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions interface/forms_admin/forms_admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,6 @@
{
// added 8-2009 by BM - do not show the metric vitals form as option since deprecated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the comments related to this code as well then it will be ready for merge.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great.

// also added a toggle in globals.php in case user wants the option to add this deprecated form
if (($fname == "vitalsM") && ($GLOBALS['disable_deprecated_metrics_form'])) continue;

if (stristr($fname, ".tar.gz") || stristr($fname, ".tar") || stristr($fname, ".zip") || stristr($fname, ".gz"))
$phpState = "PHP compressed";
else
Expand Down
13 changes: 3 additions & 10 deletions library/globals.inc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,16 +431,9 @@
),
'1',
xl('Applies to Vitals form')
)
,
'disable_deprecated_metrics_form' => array(
xl('Disable Old Metric Vitals Form'),
'bool', // data type
'1', // default = true
ahanipeitra1994 marked this conversation as resolved.
Show resolved Hide resolved
xl('This was the older metric-only Vitals form, now deprecated.')
),

'phone_country_code' => array(
) ,

'phone_country_code' => array(
xl('Telephone Country Code'),
'num',
'1', // default = North America
Expand Down