Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filtering for expected Turnstile errors in Sentry #2573

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

joshuastegmaier
Copy link
Collaborator

@joshuastegmaier joshuastegmaier commented Oct 25, 2024

https://staff.loc.gov/tasks/browse/CONCD-976

I was unable to get these errors, at least the 600xxx ones, to log in my dev environment even before adding the filter (I was able to get Sentry to capture other messages, so it seems like it doesn't log 600xxx errors by default--I kept the filter to be safe). I was unable to trigger the 300xxx at all, since Turnstile doesn't provide a way to do so. Testing will need to be done in dev/test, to the extent it can be tested at all, since it depends on the user failing Turnstile validation.

@joshuastegmaier joshuastegmaier marked this pull request as ready for review October 25, 2024 17:00
@jkueloc jkueloc merged commit 6f810ac into main Oct 25, 2024
7 checks passed
@joshuastegmaier joshuastegmaier deleted the CONCD-976-jstegmaier-turnstile-errors branch November 20, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants