Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ref to macOS not having date -I #230

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

alex-ball
Copy link
Contributor

The -I option was added to the FreeBSD version of date in FreeBSD 12.0, and is therefore available in newer versions of macOS. While technically it is true that this option is not in MacOS X and possibly macOS 11 (Big Sur), it may cause confusion to highlight it when most learners on macOS will have a version that supports the option.

Recreates auto-closed PR #217.

The `-I` option was added to the FreeBSD version of `date` in FreeBSD 12.0, and is therefore available in newer versions of macOS. While technically it is true that this option is not in MacOS X and possibly macOS 11 (Big Sur), it may cause confusion to highlight it when most learners on macOS will have a version that supports the option.

Recreates auto-closed PR LibraryCarpentry#217.
@github-actions
Copy link

github-actions bot commented May 9, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-shell/compare/md-outputs..md-outputs-PR-230

The following changes were observed in the rendered markdown documents:

 05-counting-mining.md | 2 +-
 md5sum.txt            | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-05-09 09:23:07 +0000

github-actions bot pushed a commit that referenced this pull request May 9, 2023
Now that only legacy BSD implementations of `date` don't support the `-I` option, and Macs no longer ship with these, it is fair to say "most" rather than "some" platforms support it.
github-actions bot pushed a commit that referenced this pull request May 9, 2023
@kaitlinnewson kaitlinnewson merged commit f12bc88 into LibraryCarpentry:main Aug 22, 2023
github-actions bot pushed a commit that referenced this pull request Aug 22, 2023
Auto-generated via {sandpaper}
Source  : f12bc88
Branch  : main
Author  : Kaitlin Newson <[email protected]>
Time    : 2023-08-22 15:12:04 +0000
Message : Merge pull request #230 from alex-ball/patch-2

Remove ref to macOS not having `date -I`
github-actions bot pushed a commit that referenced this pull request Aug 22, 2023
Auto-generated via {sandpaper}
Source  : 79f0253
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-08-22 15:13:30 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f12bc88
Branch  : main
Author  : Kaitlin Newson <[email protected]>
Time    : 2023-08-22 15:12:04 +0000
Message : Merge pull request #230 from alex-ball/patch-2

Remove ref to macOS not having `date -I`
github-actions bot pushed a commit that referenced this pull request Aug 22, 2023
Auto-generated via {sandpaper}
Source  : 79f0253
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-08-22 15:13:30 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f12bc88
Branch  : main
Author  : Kaitlin Newson <[email protected]>
Time    : 2023-08-22 15:12:04 +0000
Message : Merge pull request #230 from alex-ball/patch-2

Remove ref to macOS not having `date -I`
@alex-ball alex-ball deleted the patch-2 branch August 25, 2023 09:46
github-actions bot pushed a commit that referenced this pull request Aug 29, 2023
Auto-generated via {sandpaper}
Source  : 79f0253
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-08-22 15:13:30 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f12bc88
Branch  : main
Author  : Kaitlin Newson <[email protected]>
Time    : 2023-08-22 15:12:04 +0000
Message : Merge pull request #230 from alex-ball/patch-2

Remove ref to macOS not having `date -I`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants