sync fork for major update #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change markup of `for loop` from back ticks to asterisks: *for loop*.
Update 06-for-loops.md
update zip of CSV files
Fix broken links to plotly interactive HTML charts.
add replacement dates
changing from pre-alpha to alpha
updating zip file to contain pkl
removing matplot explicit use
adding date conversion part to tidy.md
removing date from data-visualisation.md
Maintainers have taught twice so bumping up to beta
fixes #90
|
tobyhodges
approved these changes
Jun 17, 2024
config.yaml
Outdated
| @@ -14,14 +14,15 @@ carpentry: 'lc' | |||
| title: 'Python Intro for Libraries' | |||
|
|
|||
| # Date the lesson was created (YYYY-MM-DD, this is empty by default) | |||
| created: '2018-04-12' | |||
| created: '2024-05-24' | |||
There was a problem hiding this comment.
Is it your intention to set a new creation date? Is this version effectively a completely new lesson, rather than a modification of what was here before? In my view, the creation date is best aligned with the beginning of the repository commit history...
There was a problem hiding this comment.
Thanks @tobyhodges! It is a major revision, but not completely new, so I changed the created date back to 2018.
Comment on lines
-62
to
+75
| - 01-getting-started.md | ||
| - 02-variables.md | ||
| - 03-types-conversion.md | ||
| - 04-built-in.md | ||
| - 05-coffee.md | ||
| - 06-libraries.md | ||
| - 10-lunch.md | ||
| - 11-lists.md | ||
| - 12-for-loops.md | ||
| - 13-looping-data-sets.md | ||
| - 14-writing-functions.md | ||
| - 15-scope.md | ||
| - 16-coffee.md | ||
| - 17-conditionals.md | ||
| - 18-style.md | ||
| - 19-wrap.md | ||
| - 20-feedback.md | ||
| - getting-started.md | ||
| - variables.md | ||
| - lists.md | ||
| - functions.md | ||
| - libraries.md | ||
| - for-loops.md | ||
| - looping-data-sets.md | ||
| - pandas.md | ||
| - conditionals.md | ||
| - writing-functions.md | ||
| - tidy.md | ||
| - data-visualisation.md | ||
| - wrap.md |
There was a problem hiding this comment.
This is most likely the reason why you could not automatically sync your fork with the LC lesson on GitHub: a large number of the files have changed name, which has a tendency to confuse Git.
github-actions bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
Auto-generated via {sandpaper}
Source : c8280dc
Branch : main
Author : Cody Hennesy <[email protected]>
Time : 2024-06-17 13:37:46 +0000
Message : Merge pull request #117 from chennesy/resolved
major lesson update
github-actions bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
Auto-generated via {sandpaper}
Source : e4a3a45
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2024-06-17 13:39:10 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : c8280dc
Branch : main
Author : Cody Hennesy <[email protected]>
Time : 2024-06-17 13:37:46 +0000
Message : Merge pull request #117 from chennesy/resolved
major lesson update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to update local chennesy repo with changes from LibraryCarpentry repo before replacing the LibraryCarpentry python lesson with the updated one at chennesy/