-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update supported and tested version on Getting Ready (setup.md) #333
Conversation
I updated the version that this lesson is tested with from 3.6.1 to 3.7.7. I taught this lesson through episode 9, and everything worked correctly with the latest version of Open Refine that I had downloaded (3.7.7).
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-open-refine/compare/md-outputs..md-outputs-PR-333 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-01-17 22:49:11 +0000 |
@jas58 , I mentioned this PR during our Maintainers Meeting today, and I was able to make the PR and submit it. Hopefully it's helpful, but as I didn't teach all the way through the lesson, I can understand it you want it to be more completely tested. |
Thanks so much for doing this @emcaulay |
Auto-generated via {sandpaper} Source : ecc456b Branch : main Author : Owen Stephens <[email protected]> Time : 2024-02-09 15:10:44 +0000 Message : Merge pull request #333 from emcaulay/patch-1 Update supported and tested version on Getting Ready (setup.md)
Auto-generated via {sandpaper} Source : af90b19 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-02-09 15:11:55 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : ecc456b Branch : main Author : Owen Stephens <[email protected]> Time : 2024-02-09 15:10:44 +0000 Message : Merge pull request #333 from emcaulay/patch-1 Update supported and tested version on Getting Ready (setup.md)
I updated the version that this lesson is tested with from 3.6.1 to 3.7.7.
I taught this lesson through episode 9, and everything worked correctly with the latest version of Open Refine that I had downloaded (3.7.7).