Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken link to Working with Data #327

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

maneesha
Copy link
Contributor

Broken link to "Working with Data" from https://librarycarpentry.org/lc-open-refine/aio.html#arrays

Copy link

github-actions bot commented Nov 22, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-open-refine/compare/md-outputs..md-outputs-PR-327

The following changes were observed in the rendered markdown documents:

 11-using-arrays-transformations.md | 3 +--
 md5sum.txt                         | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-12-15 15:32:30 +0000

github-actions bot pushed a commit that referenced this pull request Nov 22, 2023
Copy link
Contributor

@ostephens ostephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for spotting this. Since we're updating the link I wonder if it would be better to the specific section of that page? https://librarycarpentry.org/lc-open-refine/03-working-with-data#choosing-a-good-separator

@jas58
Copy link
Contributor

jas58 commented Nov 22, 2023

It looks like @maneesha was using the All in One view (which I use as an instructor, too). Though it's actually the part in episode 12, on exporting data. Is that correct?

And @ostephens is verifying the link should go towards: https://librarycarpentry.org/lc-open-refine/03-working-with-data.html#choosing-a-good-separator

Also, there's an extra full stop at the end of that sentence.

Will editing the aio file also update the right episode file?

As an internal reference, does this need the .md instead of .html? I don't recall how that works with hashtags to subsections.

@ostephens
Copy link
Contributor

Though it's actually the part in episode 12, on exporting data. Is that correct?

Just for clarity it's in episode 11 (which you link to)

Will editing the aio file also update the right episode file?

It would not - but the edit has been done on the correct file episodes/11-using-arrays-transformations.md so it is being done in the right place as far as I can see

As an internal reference, does this need the .md instead of .html? I don't recall how that works with hashtags to subsections.

Good catch - yes this should use the internal link syntax and that will work with the hash / fragment as well. See https://carpentries.github.io/sandpaper-docs/episodes.html#internal-links

Copy link
Contributor

@jas58 jas58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you, Owen.

Updated line 65 to md version and specific moment in lesson
03-working-with-data.md#choosing-a-good-separator
@jas58 jas58 requested a review from ostephens December 15, 2023 15:32
github-actions bot pushed a commit that referenced this pull request Dec 15, 2023
@ostephens ostephens merged commit 0ae7aa0 into main Jan 9, 2024
3 checks passed
@ostephens ostephens deleted the broken-link-to-working-with-data branch January 9, 2024 17:19
github-actions bot pushed a commit that referenced this pull request Jan 9, 2024
Auto-generated via {sandpaper}
Source  : 0ae7aa0
Branch  : main
Author  : Owen Stephens <[email protected]>
Time    : 2024-01-09 17:19:14 +0000
Message : Merge pull request #327 from LibraryCarpentry/broken-link-to-working-with-data

fix broken link to Working with Data
github-actions bot pushed a commit that referenced this pull request Jan 9, 2024
Auto-generated via {sandpaper}
Source  : 2c92cf2
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-01-09 17:20:28 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 0ae7aa0
Branch  : main
Author  : Owen Stephens <[email protected]>
Time    : 2024-01-09 17:19:14 +0000
Message : Merge pull request #327 from LibraryCarpentry/broken-link-to-working-with-data

fix broken link to Working with Data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants