-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated href #317 and made text accessible #318
Conversation
Issue #317 identified an outdated link with the new location. I went on to make the hyperlinked text screenreader accessible by giving it a descriptive, non-url phrase.
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-open-refine/compare/md-outputs..md-outputs-PR-318 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-10-20 13:59:19 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Could you update the PR description to include "closes #317"? Then merging it automatically closes the issue.
Thank you, @bencomp That's a new piece I'll try to incorporate going forward. |
Auto-generated via {sandpaper} Source : 488ab1d Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2023-10-25 15:54:11 +0000 Message : Merge pull request #318 from LibraryCarpentry/jas58-patch-1 Close #317 updated href and made text accessible
Auto-generated via {sandpaper} Source : 5585717 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-10-25 15:55:45 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 488ab1d Branch : main Author : Jennifer Stubbs <[email protected]> Time : 2023-10-25 15:54:11 +0000 Message : Merge pull request #318 from LibraryCarpentry/jas58-patch-1 Close #317 updated href and made text accessible
Issue #317 identified an outdated link with the new location. I went on to make the hyperlinked text screenreader accessible by giving it a descriptive, non-url phrase.
closes #317
closes #317