Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated href #317 and made text accessible #318

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Updated href #317 and made text accessible #318

merged 1 commit into from
Oct 25, 2023

Conversation

jas58
Copy link
Contributor

@jas58 jas58 commented Oct 20, 2023

Issue #317 identified an outdated link with the new location. I went on to make the hyperlinked text screenreader accessible by giving it a descriptive, non-url phrase.
closes #317
closes #317

Issue #317 identified an outdated link with the new location.  I went on to make the hyperlinked text screenreader accessible by giving it a descriptive, non-url phrase.
@github-actions
Copy link

github-actions bot commented Oct 20, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-open-refine/compare/md-outputs..md-outputs-PR-318

The following changes were observed in the rendered markdown documents:

 05-clustering.md | 2 +-
 md5sum.txt       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-10-20 13:59:19 +0000

github-actions bot pushed a commit that referenced this pull request Oct 20, 2023
@jas58 jas58 requested a review from ostephens October 20, 2023 14:00
Copy link
Contributor

@bencomp bencomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Could you update the PR description to include "closes #317"? Then merging it automatically closes the issue.

@jas58 jas58 merged commit 488ab1d into main Oct 25, 2023
3 checks passed
@jas58 jas58 deleted the jas58-patch-1 branch October 25, 2023 15:54
@jas58
Copy link
Contributor Author

jas58 commented Oct 25, 2023

Thank you, @bencomp That's a new piece I'll try to incorporate going forward.

github-actions bot pushed a commit that referenced this pull request Oct 25, 2023
Auto-generated via {sandpaper}
Source  : 488ab1d
Branch  : main
Author  : Jennifer Stubbs <[email protected]>
Time    : 2023-10-25 15:54:11 +0000
Message : Merge pull request #318 from LibraryCarpentry/jas58-patch-1

Close #317 updated href and made text accessible
github-actions bot pushed a commit that referenced this pull request Oct 25, 2023
Auto-generated via {sandpaper}
Source  : 5585717
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-10-25 15:55:45 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 488ab1d
Branch  : main
Author  : Jennifer Stubbs <[email protected]>
Time    : 2023-10-25 15:54:11 +0000
Message : Merge pull request #318 from LibraryCarpentry/jas58-patch-1

Close #317 updated href and made text accessible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Clustering In Depth link
2 participants