Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link URL for issue listing #157

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

tobyhodges
Copy link
Member

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Fixes #154

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

It seems this link was misconfigured in #147, so the link in CONTRIBUTING.md was pointing to example.com instead of the lesson repository. This PR corrects the URL for the link.

@github-actions
Copy link

github-actions bot commented Oct 18, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-git/compare/md-outputs..md-outputs-PR-157

The following changes were observed in the rendered markdown documents:


What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-10-18 10:52:26 +0000

github-actions bot pushed a commit that referenced this pull request Oct 18, 2023
Copy link
Contributor

@emcaulay emcaulay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tobyhodges ! I hadn't thought to look at the end of the MD file. Accepting your changes now!

@emcaulay emcaulay merged commit ff7e769 into main Oct 19, 2023
3 checks passed
@emcaulay emcaulay deleted the fix-contributing-issues-link branch October 19, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in link on page CONTRIBUTING.md
2 participants