Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI, docker base, and healthcheck #48

Merged
merged 4 commits into from
Jan 3, 2024

Conversation

wilwade
Copy link
Member

@wilwade wilwade commented Jan 3, 2024

Problem

Needed to update the base docker base and make sure the health check was correct for loading the schemas instead of just that the rpc was available.

Solution

@wilwade wilwade requested review from pfrank13 and wesbiggs January 3, 2024 16:53
Copy link
Collaborator

@pfrank13 pfrank13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally for my purposes and passes

Copy link
Member

@wesbiggs wesbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a couple doc suggestions.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
scripts/deploy_schemas_to_node.sh Show resolved Hide resolved
@wilwade wilwade requested a review from wesbiggs January 3, 2024 17:59
Copy link
Member

@wesbiggs wesbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@wilwade wilwade merged commit bff0997 into main Jan 3, 2024
1 check passed
@wilwade wilwade deleted the chore/update-docker-healthcheck branch January 3, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dsnp/instant-seal-node-with-deployed-schemas to dsnp/standalone-node-with-deployed-schemas
3 participants