Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX]상품 출력 페이지, custom표시 수정 #248

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[FIX]상품 출력 페이지, custom표시 수정 #248

wants to merge 1 commit into from

Conversation

KimHyeongKeun
Copy link
Member

  • custom === true 일때 license로 표시되었던 것 custom으로 표기

@KimHyeongKeun KimHyeongKeun added the 🐞 BugFix Something isn't working label Oct 25, 2023
@KimHyeongKeun KimHyeongKeun self-assigned this Oct 25, 2023
heeoneie
heeoneie requested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@heeoneie heeoneie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 부탁드려요

src/axios/order/Order.js
return new Promise((res) => {
axios
.get(
`/product/products?page=${page}&size=${size}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Api는 따로 관리하는게 좋을 것 같습니다

아마 constants 폴더 안에 있어요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 알겠습니다!

2hanbyeol1
2hanbyeol1 reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@2hanbyeol1 2hanbyeol1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다음부터는 navigate 사용할 때 PATH.js의 변수 사용해주세요 🥹👍

src/screen/order/Choose.js Show resolved Hide resolved
src/screen/order/Order.js Show resolved Hide resolved
@jungyeons jungyeons requested review from jungyeons and removed request for jungyeons November 14, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2hanbyeol1 2hanbyeol1 2hanbyeol1 left review comments

@heeoneie heeoneie heeoneie requested changes

@jungyeons jungyeons Awaiting requested review from jungyeons

Requested changes must be addressed to merge this pull request.

Assignees

@KimHyeongKeun KimHyeongKeun

Labels
🐞 BugFix Something isn't working
Projects
Sprint Backlog
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KimHyeongKeun @heeoneie @2hanbyeol1 @jungyeons