-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/gpu decode #44
Feat/gpu decode #44
Conversation
Reviewer's Guide by SourceryThis pull request introduces GPU decoding support as an experimental feature. It adds a Sequence diagram for GPU video decoding processsequenceDiagram
participant User
participant GPUVideoSampler
participant CUDA
participant NvDecoder
User->>GPUVideoSampler: sample(video_path)
GPUVideoSampler->>CUDA: init()
GPUVideoSampler->>CUDA: create context
GPUVideoSampler->>NvDecoder: create decoder
loop For each packet
NvDecoder->>NvDecoder: decode frame
NvDecoder->>GPUVideoSampler: return decoded frame
GPUVideoSampler->>GPUVideoSampler: process frame
end
GPUVideoSampler->>CUDA: cleanup context
Class diagram showing the new GPU sampler implementationclassDiagram
class BaseSampler {
+sample(video_path: str)
+write_queue(path: str, q: Queue, subs: str)
+init_sampler()
}
class VideoSampler {
+sample(video_path: str, subs: str)
+write_queue(video_path: str, q: Queue, subs: str)
}
class GPUVideoSampler {
+sample(video_path: str, subs: str)
note for GPUVideoSampler "New GPU-based implementation"
}
BaseSampler <|-- VideoSampler
VideoSampler <|-- GPUVideoSampler
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @LemurPwned - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Add experimental GPU decoding support for NVIDIA GPUs. Update documentation to describe the new feature and its limitations.
New Features:
Tests: