Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repick data #91

Closed
wants to merge 8 commits into from
Closed

Repick data #91

wants to merge 8 commits into from

Conversation

pawelkulig1
Copy link
Collaborator

@pawelkulig1 pawelkulig1 commented Apr 24, 2018

Allows easily repick data. Fix:
#88, #63
Creates:
#89
Has:
#90

@pawelkulig1 pawelkulig1 requested a review from LemurPwned April 24, 2018 21:29
@pawelkulig1 pawelkulig1 added this to the GUI imporvements milestone Apr 24, 2018
@pawelkulig1
Copy link
Collaborator Author

In my opinion ready to merge tbh.

@LemurPwned
Copy link
Owner

OK so I have an error which looks like that:
btw is it necessary to add a dependency on glut?

screenshot from 2018-04-26 12-11-39

@pawelkulig1
Copy link
Collaborator Author

I was testing and forgot to delete that, no new dependencies are required

gl.glColor3f(1.0, 1.0, 1.0)
gl.glWindowPos2d(100, 100)
for ch in text:
glutBitmapCharacter(GLUT_BITMAP_TIMES_ROMAN_24, (ord(ch)))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe here we must call gluInit() first

main.py Outdated
continue
self.deleteWidget(i, False)

self.doh = DataObjectHolder()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok this is a good idea but can we do smth with doh reinstatiation? It might be sufficient to clean it, because it might contain other structs necessary for the app, not particularly for widget

@pawelkulig1
Copy link
Collaborator Author

I will fix that a soon as I'm get back home

@pawelkulig1
Copy link
Collaborator Author

pawelkulig1 commented Apr 26, 2018

Sorry for that now it seems to be cleaned.

@LemurPwned
Copy link
Owner

After prompting directory reselection follwing scenery :) appears and app crashes:
screenshot from 2018-04-27 11-39-43

I will close for now until it is fully resolved ok?
It might be a Linux specific problem so if you want I can take care of this.

@LemurPwned LemurPwned closed this Apr 27, 2018
@pawelkulig1
Copy link
Collaborator Author

Crash is caused by None in regex, this is only GUI issue and has no impact on program.

@pawelkulig1 pawelkulig1 reopened this Apr 27, 2018
@LemurPwned
Copy link
Owner

LemurPwned commented Apr 27, 2018

No, it does not. I havent even repicked I directory yet?
It does not even prompt directory reselect window, just crashes.
None in regex would raise an error (Attribtute or Value), in this case nothing is raised

@pawelkulig1
Copy link
Collaborator Author

Ok I'll take a look.

@pawelkulig1
Copy link
Collaborator Author

Please provide error log, I cannot reproduce it from your description. The only issue I found is connected with regex problem. Which as far as I am concerned is already fixed on your's branch.

@LemurPwned
Copy link
Owner

Ok so maybe check first and merge #85 and I will remerge master into this branch and try to reproduce the error. Btw I will enable logging because it sigkill by python, no error raised which indicated qt fault.

@LemurPwned
Copy link
Owner

I gave my "solution" to a problem on branch #repickDataFix
User has to prompt reselection dialog again but at least no bug

@LemurPwned LemurPwned reopened this Apr 27, 2018
@LemurPwned LemurPwned mentioned this pull request Apr 27, 2018
@pawelkulig1
Copy link
Collaborator Author

Check it now.

@LemurPwned
Copy link
Owner

You mean commit 163a61b ? This does not fix the thing at all, it just changes Pop Up windows

@pawelkulig1
Copy link
Collaborator Author

Please provide exact scenario when crash occurs, what data what options, what clicked, step by step.

@LemurPwned
Copy link
Owner

LemurPwned commented May 9, 2018

  1. Load any data
  2. Select any widget
  3. Click File-> load directory
  4. Crash (sigkill no err message)

@LemurPwned LemurPwned mentioned this pull request May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants