Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW ICONS]: Flyio, Chartjs & Docsify #162

Merged
merged 2 commits into from Jul 7, 2024
Merged

[NEW ICONS]: Flyio, Chartjs & Docsify #162

merged 2 commits into from Jul 7, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jul 7, 2024 •
edited by LelouchFR
Loading

Add New Icon(s)

Icon Details

Icon ID Icon
flyio flyio
chartjs-auto chartjs-auto
chartjs-dark chartjs-dark
chartjs-light chartjs-light
docsify-auto docsify-auto
docsify-dark docsify-dark
docsify-light docsify-light

Notes

  • Fly.io is a platform designed for deploying and running containerized applications globally.
  • Chart.js is a popular JavaScript library used for creating responsive and interactive charts and graphs on web pages.
  • Docsify is a lightweight, flexible, and feature-rich documentation site generator that leverages Markdown files to generate beautiful, responsive documentation websites.

Closing

closes #161, closes #159, closes tandpfun/skill-icons#146

Checklist

  • Added icon(s) to the appropriate directory
  • Updated documentation with the new icon(s)
  • Verified the icon(s) display correctly
  • If the icon has light and dark, verified the auto switch works correctly

@ghost
Copy link
Author

ghost commented Jul 7, 2024

i was confused of what to do with the stroke color on light mode 😕

chartjs-light

@JuanPabloDiaz
Copy link

"I am impressed; issues get resolved in no time here. You guys rock!"

LelouchFR
LelouchFR approved these changes Jul 7, 2024
View reviewed changes
Copy link
Owner

@LelouchFR LelouchFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LelouchFR LelouchFR merged commit 089339d into LelouchFR:main Jul 7, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NEW ICON] Chart.js [NEW ICON]: Chart.js [NEW ICON]: Docsify
2 participants
@JuanPabloDiaz @LelouchFR