Runner #5
Open
Runner #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks OK. But I have these questions:
|
|
This Runner class is just a quick and dirty way to test the rest of the code. I haven't made any changes that should affect the android branch. It could be that the master branch is just behind the android branch. Will fix the indenting. |
|
The runnable changes may affect android branch. Will look further into that. |
|
The android branch is strange. It doesn't contain the rest of the code, so I'm curious about how its even built. I don't have the android SDK myself, but the one change I'd think would need to be made is now in my AndroidRunnable branch. |
| public String connect_packet_error_abort() { return "connect_error_abort()"; } | ||
| } | ||
|
|
||
| public static void main(String[] args) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a number of bugs that prevented the Bot from even connecting to an MCPE server. Before it would hang infinitely during initialization in ReceivedRaknetPacket.registerTypes(). Also found a null pointer issue in SentRaknetPacket.sendTo().