Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Misc Mappings #283

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

My-Name-Is-Jeff
Copy link

No description provided.

Copy link
Member

@thecatcore thecatcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a conflicts around BlockPos.BITS_X, resolve it and I'll take a look again.

Overall your pull request looks good to me.

FIELD field_0_5760 BIT_SHIFT_Y I
FIELD field_0_5761 BIT_SHIFT_X I
FIELD field_0_5763 BITS_Y J
FIELD field_10973 BITS_X J
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which version did you map this? I know for sure it's supposed to be BITS_Z for 1.14-Snapshots+. I hope it's not a mismatch on intermediary side.

@@ -15,12 +18,17 @@ CLASS net/minecraft/class_2338 net/minecraft/util/math/BlockPos
FIELD field_10980 ORIGIN Lnet/minecraft/class_2338;
COMMENT The block position which x, y, and z values are all zero.
FIELD field_10981 BIT_SHIFT_X I
FIELD field_10982 BITS_Z J
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be BIT_MASK_CHUNK_SECTION in 1.14-Snapshots according to yarn mappings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants