Skip to content

Commit

Permalink
Merge pull request softprops#75 from softprops/default-to-latest-dock…
Browse files Browse the repository at this point in the history
…er-tag

default to 'latest' docker tag
  • Loading branch information
softprops authored Jun 29, 2020
2 parents a547f94 + f524ba4 commit 48f3e2c
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 6 deletions.
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
# ⚡ 0.3.8s
# ⚡ 0.4.0 (unreleased)

* use `latest` docker tag by default. This reduces some of the maintenance in publishing this plugin. Users are still able to pin versions as they always have.

# ⚡ 0.3.8

* experimental dockerless mode! To enable local builds add the following to your `serverless.yml` file

Expand Down
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const path = require("path");
const AdmZip = require("adm-zip");
const { mkdirSync, writeFileSync, readFileSync } = require("fs");

const DEFAULT_DOCKER_TAG = "0.2.7-rust-1.43.1";
const DEFAULT_DOCKER_TAG = "latest";
const DEFAULT_DOCKER_IMAGE = "softprops/lambda-rust";
const RUST_RUNTIME = "rust";
const BASE_RUNTIME = "provided";
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions tests/unit/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ describe("RustPlugin", () => {
assert.deepEqual(unconfigured.custom, {
cargoFlags: "",
dockerImage: "softprops/lambda-rust",
dockerTag: "0.2.7-rust-1.43.1",
dockerTag: "latest",
dockerless: false,
});
});
Expand All @@ -50,7 +50,7 @@ describe("RustPlugin", () => {
rust: {
cargoFlags: "--features foo",
dockerImage: "notsoftprops/lambda-rust",
dockerTag: "latest",
dockerTag: "custom-tag",
dockerless: true,
},
},
Expand All @@ -63,7 +63,7 @@ describe("RustPlugin", () => {
assert.deepEqual(configured.custom, {
cargoFlags: "--features foo",
dockerImage: "notsoftprops/lambda-rust",
dockerTag: "latest",
dockerTag: "custom-tag",
dockerless: true,
});
});
Expand Down

0 comments on commit 48f3e2c

Please sign in to comment.