Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
WooGi1020
approved these changes
Jan 21, 2025
src/utils/useLogout.ts
Outdated
|
|
||
| const onLogout = () => { | ||
| localStorage.removeItem('accessToken'); | ||
| localStorage.removeItem('refreshToken'); |
There was a problem hiding this comment.
아마 리프레시토큰은 쿠키에 있어서 client.ts 가 처리해줄거라 localStorage 에는 따로 저장 안될거에요!!
There was a problem hiding this comment.
아하 그럼 일단 accessToken만 localStorage에서 삭제하고 refreshToken은 쿠키에서 삭제하는걸로 수정할게요!
src/utils/useWithDraw.ts
Outdated
There was a problem hiding this comment.
utils 폴더는 자잘한 작업을 처리하기 위한 (format 같은 로직처리) 함수들을 모아놓는 폴더여서 함수 목적에 조금 더 부합하는 hook 폴더에 위치시키시거나 아니면 그냥 탈퇴하기 사용하는 로직에서 직접적으로 사용해주셔도 무방할 것 같습니다..!! 😁
There was a problem hiding this comment.
아항 그럼 hooks 폴더에 위치시키는 걸로 수정하겠습니당 !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 무슨 이유로 코드를 변경했나요?
2. 어떤 위험이나 장애를 발견했나요?
3. 관련 스크린샷을 첨부해주세요.
4. 완료 사항
마이페이지 모달 UI를 구현하였습니다
5. 추가 사항
현재 탈퇴하기
api는 안나왔지만 로직만 구현해놓은 상태입니다!