Feat: 친구 목록 및 블랙리스트 UI 작성 #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woneeeee
approved these changes
Jan 20, 2025
| (member) => member.id !== blackMember.id, | ||
| ); | ||
| setBlackList(updatedList); | ||
| openToast('블랙리스트에서 삭제되었어요'); |
There was a problem hiding this comment.
이건 회의때 디자이너 분과 얘기해봐도 좋을 것 같은데
openToast(`${blackMember.nickName}님이 블랙리스트에서 삭제되었습니다.`);
이런식으로 이름을 명확하게 해줘도 좋을 것 같아요
There was a problem hiding this comment.
요것도 좋은 것 같아요!! 내일 회의떄 함 말해보시져 👍
|
|
||
| return ( | ||
| <div className="bg-toastColor rounded-box p-vertical flex items-center justify-between h-[101px]"> | ||
| <div className="flex-1 flex items-center gap-[16px]"> |
There was a problem hiding this comment.
제가 알기론 테일윈드에서 16px과 4가 같은데 px 사용보단 테일윈드 자체 css를 쓰는게 좋다고 들어서 gap-[16px]이라면 gap-4로 변경해줘도 좋을 것 같아요!
| </Button> | ||
| </div> | ||
|
|
||
| {renderConditionalComponents()} |
There was a problem hiding this comment.
이렇게 따로 컴포넌트로 빼놓으니까 가독성이 훨씬 좋아보이네요! 👍🏻
|
|
||
| export interface Friend { | ||
| id: number; | ||
| profileImage: string; |
There was a problem hiding this comment.
여기서 profileImage를 선택적으로 처리하면 디폴트 이미지 처리를 할 수 있으니까
profileImage?: string;
이런식ㅇ으로 해도 좋을 것 같아요!
There was a problem hiding this comment.
좋습니다!! 반영해놓을게요 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 무슨 이유로 코드를 변경했나요?
2. 어떤 위험이나 장애를 발견했나요?
3. 관련 스크린샷을 첨부해주세요.
4. 완료 사항
친구 목록 및 블랙리스트 UI와 친구 삭제 모달, 토스트 부분 UI 작성했습니다!
그리고
RouteSetting컴포넌트가 모바일뷰에서 볼 경우에 깨져보였는데 따로 이슈 파는건 애매할 것 같아서 일단 이번 이슈에서 수정해보려고 합니다!!5. 추가 사항