Feat: 시연 때 발생한 오류 및 에러 페이지 적용 #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
woneeeee
approved these changes
Feb 8, 2025
| @@ -90,7 +90,7 @@ const MatchingInfoItem = ({ | |||
| <div className="flex-1 overflow-y-scroll scroll-hidden overflow-hidden mt-5"> | |||
| <p className="font-medium text-body"> | |||
| <span>추가 멘트 : </span> | |||
| {manualInfo.description} | |||
| {manualInfo.description ? manualInfo.description : 'X'} | |||
There was a problem hiding this comment.
오 없을때 이렇게 표현해주는게 훨씬 나을듯 하네요! 👍🏻👍🏻
| @@ -7,7 +14,7 @@ const Tags = ({ tags }: { tags: string[] }) => { | |||
| key={tag} | |||
| className="text-assistive min-w-fit text-black font-medium px-3 py-1 rounded-full bg-primary" | |||
| > | |||
| # {tag} | |||
| # {showLabel(tag)} | |||
There was a problem hiding this comment.
엇 영어로 보이던 tag들 수정됐군요! 감사합니당 🙇🏻♀️
There was a problem hiding this comment.
흐억 이 부분 마지막 날에 급하게 하느라고... 코드가 좀 이상했는데 수정해주셨네요 감사합니닷 ...!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 무슨 이유로 코드를 변경했나요?
2. 어떤 위험이나 장애를 발견했나요?
3. 관련 스크린샷을 첨부해주세요.
4. 완료 사항
시연떄 발생헀던 자잘한 오류들 (태그 데이터형태 그대로 출력, 블랙리스트 이미지 누락 등) 수정하고 만들어두신 에러 페이지
react-error-boundary라이브러리 사용해서 적용했습니다~5. 추가 사항