Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat #20 카카오 로그인 로직 변경 #21
Feat #20 카카오 로그인 로직 변경 #21
Changes from 12 commits
288dd3d
7815143
93aead6
36c7806
ce5ede4
197fcf5
5c1a8a1
0e5d6a6
b6b2ea3
7dc49bf
5816cdb
983b10c
2038155
a3d2e44
c168c7a
3818a46
9deb9f9
0fdc43d
dbaa479
863cd2a
d6f4cad
feca89d
650522c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그냥 null로 저장이 되면 될 것 같은데, 차후에 개선 부탁드릴게요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 저희는 로직상 이메일 인증 로직이 따로 되어있고, 이메일 인증 로직시 입력받는 가천 이메일의 정보로 유저를 식별 가능하니까,
실제 이메일이 입력되기 전까지는 해당 이메일 필드를 null로 저장하는 것이 더 적합해보이긴합니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
실제 DB에서 임시 유저의 Email은 null로 저장하고
토큰을 만들기 위해서는 더미 이메일을 넣어주도록 수정했습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
role은 차후에 admin, user를 구분할 때 쓰여야할 것 같은데, status나 deletedAt을 사용하는 것은 어떨까요?
기본 유저 객체 생성시 @PrePersist로 status를 UNACTIVE로 설정하거나, 아니면 소프트 딜리트가 적용된 상태를 기본 상태로 두고
회원가입이 완료되면 status를 바꾸거나, 소프트 딜리트 된것을 해제하는 식으로요!
이렇게 전역적으로 관리를 해두면 차후 로직에서 user를 조회해올 때 ACTIVE인 유저만 조회하기, 혹은 삭제되지 않은 유저만 조회하기 등으로 일관성있는 개발이 가능할 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 status로 관리하면 좋을 것 같습니다!!
저희가 메일 인증, 전화번호 인증 두 가지 인증이 있으니까 EMAIL_PENDING, PHONE_PENDING... 등의 상태를 만들어서 관리하면 좋을 것 같아요!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACTIVE와 INACTIVE인 UserStatus를 만들도록 하겠습니다!
소프트 딜리트는 좀 더 공부해보도록 하겠습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UserStatus는 회원가입 여부 (활성화 상태)만 나타내는 게 좋을거 같아요!
이미 유저 엔티티에 2차 인증 필드가 전화번호 인증을 나타내고 있기 때문에요!