fix: correct fields and add schema (#353)

* fix: correct fields and add schema
LedgerHQ · May 15, 2024 · 47547e4 · 47547e4
1 parent 54c80a8
commit 47547e4
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 5 deletions.
diff --git a/.changeset/three-jeans-buy.md b/.changeset/three-jeans-buy.md
@@ -0,0 +1,5 @@
+---
+"@ledgerhq/wallet-api-manifest-validator": minor
+---
+
+Modify fields and add $schema
diff --git a/packages/manifest-validator/src/schema/schema.ts b/packages/manifest-validator/src/schema/schema.ts
@@ -10,7 +10,8 @@ const networks = {
     type: "object",
     properties: {
       currency: {
-        enum: CURRENCIES_ID,
+        type: "string",
+        examples: CURRENCIES_ID,
       },
       chainID: {
         type: "number",
@@ -34,14 +35,17 @@ export const schema = {
   title: "Manifest schema for Wallet App",
   type: "object",
   properties: {
+    $schema: {
+      type: "string",
+    },
     id: {
       type: "string",
       minLength: 3,
       maxLength: 50,
-      pattern: "^[a-z][a-z0-9-]*$",
+      pattern: "^[a-zA-Z0-9_][a-zA-Z0-9_-]*$",
       errorMessage: {
         pattern:
-          "${0#} must start with a lowercase letter and can only contain lowercase letters, digits, or hyphens.",
+          "${0#} must start with a letter or digit and can only contain letters, digits, or hyphens.",
       },
     },
     author: {
@@ -71,6 +75,9 @@ export const schema = {
       type: "string",
       format: "uri",
     },
+    private: {
+      type: "boolean",
+    },
     platforms: {
       type: "array",
       uniqueItems: true,
@@ -102,7 +109,8 @@ export const schema = {
           type: "array",
           uniqueItems: true,
           items: {
-            enum: CURRENCIES_ID,
+            type: "string",
+            examples: CURRENCIES_ID,
           },
         },
         {
@@ -185,7 +193,7 @@ export const schema = {
     },
     permissions: {
       type: "array",
-      minItems: 1,
+      minItems: 0,
       items: {
         type: "string",
       },
@@ -253,6 +261,10 @@ export const schema = {
     "currencies",
     "content",
     "permissions",
+    "homepageUrl",
+    "branch",
+    "domains",
+    "visibility",
   ],
   additionalProperties: {
     not: true,

diff --git a/packages/manifest-validator/tests/manifests/dapp/dapp-manifest.test.json b/packages/manifest-validator/tests/manifests/dapp/dapp-manifest.test.json
@@ -16,6 +16,8 @@
   },
   "homepageUrl": "https://earn.alkemi.network",
   "supportUrl": "https://earn.alkemi.network",
+  "domains": ["https"],
+  "branch": "stable",
   "icon": "https://cdn.live.ledger.com/icons/platform/alkemi.png",
   "platforms": ["ios"],
   "apiVersion": "^1.0.0 || ~0.0.1",

diff --git a/packages/manifest-validator/tests/manifests/nativeDapp/nativeDapp-manifest.test.json b/packages/manifest-validator/tests/manifests/nativeDapp/nativeDapp-manifest.test.json
@@ -20,6 +20,8 @@
   },
   "homepageUrl": "https://earn.alkemi.network",
   "supportUrl": "https://earn.alkemi.network",
+  "domains": ["https"],
+  "branch": "stable",
   "icon": "https://cdn.live.ledger.com/icons/platform/alkemi.png",
   "platforms": ["android", "ios", "desktop"],
   "apiVersion": "^1.0.0 || ~0.0.1",

diff --git a/packages/manifest-validator/tests/manifests/walletApp/walletApp-manifest.test.json b/packages/manifest-validator/tests/manifests/walletApp/walletApp-manifest.test.json
@@ -16,6 +16,8 @@
   },
   "homepageUrl": "https://earn.alkemi.network",
   "supportUrl": "https://earn.alkemi.network",
+  "domains": ["https"],
+  "branch": "stable",
   "icon": "https://cdn.live.ledger.com/icons/platform/alkemi.png",
   "platforms": ["android"],
   "apiVersion": "^1.0.0 || ~0.0.1",