Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cx_crc_hw syscall support #510

Merged
merged 1 commit into from
Jul 30, 2024
Merged

cx_crc_hw syscall support #510

merged 1 commit into from
Jul 30, 2024

Conversation

apaillier-ledger
Copy link
Contributor

Fixes #508

@apaillier-ledger apaillier-ledger force-pushed the feat/apa/cx_crc_hw branch 3 times, most recently from 8d346d0 to 57758ad Compare July 30, 2024 14:01
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 7.69231% with 24 lines in your changes missing coverage. Please review.

Project coverage is 44.92%. Comparing base (8f8d569) to head (41e1617).

Files Patch % Lines
src/bolos/cx_crc.c 8.00% 23 Missing ⚠️
src/emulate_unified_sdk.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #510      +/-   ##
==========================================
- Coverage   44.99%   44.92%   -0.07%     
==========================================
  Files         120      120              
  Lines       12046    12064      +18     
  Branches      964      966       +2     
==========================================
  Hits         5420     5420              
- Misses       6291     6309      +18     
  Partials      335      335              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apaillier-ledger apaillier-ledger merged commit 1b4f334 into master Jul 30, 2024
36 checks passed
@apaillier-ledger apaillier-ledger deleted the feat/apa/cx_crc_hw branch July 30, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible issue using cx_crc32() when testing Stax on Speculos
3 participants