Skip to content
This repository was archived by the owner on Feb 12, 2025. It is now read-only.

Commit a2ff470

Browse files
Merge pull request #136 from KhalilBellakrid/release-process
Add some details about release process. [skip-ci]
2 parents 37055cf + 303615a commit a2ff470

File tree

4 files changed

+35
-2
lines changed

4 files changed

+35
-2
lines changed

CONTRIBUTING.md

+20
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ this same document.
1919
- `misc/`: for anything else (like adding docs, READMEs, etc.).
2020
- We open a *pull request* when we think the branch should be merged. **Becareful: when opening
2121
the pull request, select `develop` as base branch!**
22+
- Do not forget to update the CHANGELOG.md **before** opening a pull request.
2223
- We review the *pull request*. We don’t set a fixed number of reviewers, but don’t forget the
2324
golden rule: the more people review, the better.
2425
- If your change impacts no path from the CI (for instance, you just added a new tool or fixed a
@@ -32,10 +33,29 @@ this same document.
3233
to your changes.
3334
- Do the same thing in [appveyor.yml] for the `LIB_VERSION` key.
3435
- [We appologize for not having automated that yet.](#117)
36+
- Do not forget to bump the version, if needed, **before** opening a pull request
3537
- We *tag* stable releases on `master` with [SemVer].
3638
- We *tag* instable releases on `develop` with the special `-rc` suffix to support *release
3739
candidates*.
3840

41+
## Release process
42+
- Development: fixes, features are done on specific branches on developers' fork,
43+
- Pull requests: submitted to LedgerHQ/develop with updated CHANGELOG.md,
44+
- Merge into `LedgerHQ/develop`: triggers CI builds and deploys under `x.y.z-rc-commitHash`,
45+
- Merge into `LedgerHQ/master`: once a version is confirmed to be stable at least by one of our clients
46+
(Vault or Live), we bump project’s version, for this we have a special pull request. Once merged in
47+
`LedgerHQ/master` and tagged as a stable release `x.y.z`, a build and a deployment are triggered.
48+
To sum up, tags point to stable releases that are in production. **These versions should be used by any application
49+
client of libcore**
50+
- Patches: only applied on previously affected releases that has been in production, to apply a patch to a version `x.y.z`,
51+
we create a branch from master at `x.y.z` tag, push all fixes to it, once stable (confirmed by client)
52+
we tag a new patched stable release (e.g. `x.y.(z+1)`). Then this branch is merged to `LedgerHQ/develop`.
53+
Each 3/4 weeks we clean upstream from unused branches.
54+
55+
<p align="center">
56+
<img src="/ressources/patch.png" width="550"/>
57+
</p>
58+
3959
## About coin integration
4060

4161
We might accept coin integration at some day but currently, **we do not accept pull-requests that add

README.md

+14-1
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,20 @@ Generating bindings is a several steps process:
139139
```
140140
node ledger-core-samples/nodejs/tests/wallet-pool-test.js
141141
```
142-
142+
## Support
143+
144+
### Libcore:
145+
Libcore can be built for following OSes:
146+
- MacOS: minimum supported version is `macOS 9.0`, with `x86_64` architecture,
147+
- Linux: Debian (stretch), Ubuntu and Arch are supported, with `x86_64` architecture,
148+
- Windows: 64-bit architecture is built with `MSVC` (starting from Visual Studio 15), 32-bit is built with `MinGW`,
149+
- iOS: `x86_64`, `armv7` and `arm64` architectures are supported, minimum supported version is `iOS 10.0`,
150+
- Android: `x86`, `armeabi-v7a` and `arm64-v8a` architectures are supported, minimum supported version is `Android 7 (API 24)` (Java 8 is needed).
151+
### Bindings:
152+
- NodeJS bindings:
153+
- Please use `node` with version `>=8.4.0` and `<9.0.0` (other versions are not tested (yet)),
154+
- Node-gyp is used to build native module and requires `python` with version `2.7.x`.
155+
143156
## Developement guidelines
144157

145158
### CI

ressources/patch.png

202 KB
Loading

0 commit comments

Comments
 (0)