Skip to content
This repository was archived by the owner on Feb 12, 2025. It is now read-only.

Commit 303615a

Browse files
committedFeb 4, 2019
Take PR comments into consideration
1 parent 57c56b7 commit 303615a

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed
 

‎CONTRIBUTING.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,11 @@ this same document.
3939
candidates*.
4040

4141
## Release process
42-
- Development : fixes, features are done on specific branches on developers' fork,
43-
- Pull requests: submitted to LedgerHQ/develop with updated of CHANGELOG.md,
42+
- Development: fixes, features are done on specific branches on developers' fork,
43+
- Pull requests: submitted to LedgerHQ/develop with updated CHANGELOG.md,
4444
- Merge into `LedgerHQ/develop`: triggers CI builds and deploys under `x.y.z-rc-commitHash`,
45-
- Merge into `LedgerHQ/master`: once a version is confirmed to be stable by at least by one of our clients
46-
(Vault or Live), we bump project’s version, for this we jhave a special pull request. Once merged in
45+
- Merge into `LedgerHQ/master`: once a version is confirmed to be stable at least by one of our clients
46+
(Vault or Live), we bump project’s version, for this we have a special pull request. Once merged in
4747
`LedgerHQ/master` and tagged as a stable release `x.y.z`, a build and a deployment are triggered.
4848
To sum up, tags point to stable releases that are in production. **These versions should be used by any application
4949
client of libcore**

‎README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -141,14 +141,14 @@ node ledger-core-samples/nodejs/tests/wallet-pool-test.js
141141
```
142142
## Support
143143

144-
###Libcore:
144+
### Libcore:
145145
Libcore can be built for following OSes:
146146
- MacOS: minimum supported version is `macOS 9.0`, with `x86_64` architecture,
147147
- Linux: Debian (stretch), Ubuntu and Arch are supported, with `x86_64` architecture,
148148
- Windows: 64-bit architecture is built with `MSVC` (starting from Visual Studio 15), 32-bit is built with `MinGW`,
149149
- iOS: `x86_64`, `armv7` and `arm64` architectures are supported, minimum supported version is `iOS 10.0`,
150150
- Android: `x86`, `armeabi-v7a` and `arm64-v8a` architectures are supported, minimum supported version is `Android 7 (API 24)` (Java 8 is needed).
151-
###Bindings:
151+
### Bindings:
152152
- NodeJS bindings:
153153
- Please use `node` with version `>=8.4.0` and `<9.0.0` (other versions are not tested (yet)),
154154
- Node-gyp is used to build native module and requires `python` with version `2.7.x`.

0 commit comments

Comments
 (0)
This repository has been archived.