Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Progress Bar issue in long-press when releasing #769

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

nroggeman-ledger
Copy link
Contributor

Description

The goal is to fix a potential issue when using long-press button.
If the touch is releasead when the first "step" is drawn, this step is not deleted in the progress bar

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@nroggeman-ledger nroggeman-ledger force-pushed the fix-progress-bar-issue-in-long-press branch from 656d3c3 to f19d087 Compare September 19, 2024 07:53
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 35.67%. Comparing base (766b9c1) to head (f19d087).

Files with missing lines Patch % Lines
lib_nbgl/src/nbgl_screen.c 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #769       +/-   ##
===========================================
- Coverage   60.32%   35.67%   -24.65%     
===========================================
  Files          13       13               
  Lines        1807     1595      -212     
===========================================
- Hits         1090      569      -521     
- Misses        717     1026      +309     
Flag Coverage Δ
unittests 35.67% <0.00%> (-24.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nroggeman-ledger nroggeman-ledger merged commit 465476a into master Sep 19, 2024
194 checks passed
@nroggeman-ledger nroggeman-ledger deleted the fix-progress-bar-issue-in-long-press branch September 19, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants