Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX/LIVE-14165]: use spendable balance and account id for token accounts #7861

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

kallen-ledger
Copy link
Contributor

@kallen-ledger kallen-ledger commented Sep 20, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

  • use spendable balance instead of balance.
  • use parent account name as prefix for token accounts.

Screenshot 2024-09-20 at 11 38 33

❓ Context

https://ledgerhq.atlassian.net/browse/LIVE-14165


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@kallen-ledger kallen-ledger requested a review from a team as a code owner September 20, 2024 10:39
Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 9:40am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 9:40am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 9:40am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 9:40am
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 9:40am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Sep 20, 2024
@kallen-ledger kallen-ledger requested review from Justkant and a team September 20, 2024 10:45
@kallen-ledger kallen-ledger requested a review from a team as a code owner September 20, 2024 12:27
@kallen-ledger kallen-ledger merged commit 576cea3 into develop Sep 23, 2024
44 of 46 checks passed
@kallen-ledger kallen-ledger deleted the fix/LIVE-14165 branch September 23, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants