Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link 1 test case to 1 test id (Speculos x Xray) #7845

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

VicAlbr
Copy link
Contributor

@VicAlbr VicAlbr commented Sep 18, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Linked 1 test case to 1 test id

Workflow run: https://github.com/LedgerHQ/ledger-live/actions/runs/10925382147
Test execution: https://ledgerhq.atlassian.net/browse/B2CQA-2641

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 8:18am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 8:18am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 8:18am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 8:18am
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 8:18am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Sep 18, 2024
@VicAlbr VicAlbr marked this pull request as ready for review September 18, 2024 16:00
@VicAlbr VicAlbr requested review from a team as code owners September 18, 2024 16:00
@VicAlbr VicAlbr marked this pull request as draft September 19, 2024 14:45
@VicAlbr VicAlbr marked this pull request as ready for review September 24, 2024 08:14
@VicAlbr VicAlbr merged commit 2acceb5 into develop Sep 24, 2024
43 of 48 checks passed
@VicAlbr VicAlbr deleted the support/qaa164 branch September 24, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants