fix(LLD): Retry CLS installation after locking & unlocking device #7843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
fAnselmi-Ledger
force-pushed
the
bugfix/LIVE-13238-retry-CLS-after-unlocking
branch
4 times, most recently
from
1211f44
to
9ea5b78
Compare
smartine-ledger
previously approved these changes
Sep 19, 2024
valpinkman
previously approved these changes
Sep 19, 2024
...dger-live-desktop/src/renderer/components/CustomImage/CustomLockScreenDeviceAction/index.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
108
to
111
| onError && onError(error); | ||
| }, [dispatch, error, onError]); | ||
| if (!isRefusedOnStaxError) { | ||
| onError && onError(error); | ||
| } | ||
| }, [dispatch, error, onError, isRefusedOnStaxError]); |
There was a problem hiding this comment.
[ASK] Why this change ? What happens now when the user refuses the picture on the device ?
There was a problem hiding this comment.
@ofreyssinet-ledger I simplified the logic now as the prev. condition was redundant
aussedatlo
previously approved these changes
Sep 19, 2024
fAnselmi-Ledger
dismissed stale reviews from aussedatlo, valpinkman, and smartine-ledger
via
805b1ff
ofreyssinet-ledger
approved these changes
Oct 1, 2024
aussedatlo
approved these changes
Oct 1, 2024
fAnselmi-Ledger
force-pushed
the
bugfix/LIVE-13238-retry-CLS-after-unlocking
branch
from
805b1ff
to
ab262cc
Compare
themooneer
approved these changes
Oct 16, 2024
fAnselmi-Ledger
force-pushed
the
bugfix/LIVE-13238-retry-CLS-after-unlocking
branch
from
ab262cc
to
4bcd00b
Compare
fAnselmi-Ledger
deleted the
bugfix/LIVE-13238-retry-CLS-after-unlocking
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
LLD will retry CLS installation on Stax and Flex after locking & unlocking device while CLS image is being uploaded
❓ Context
🧐 Checklist for the PR Reviewers