Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIVE-13040: polkadot code cleanup #7812

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

LIVE-13040: polkadot code cleanup #7812

wants to merge 8 commits into from

Conversation

hzheng-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • **Impact of the changes: No impact
    • ...

📝 Description

Polkadot code cleanup after runtime upgrade.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@hzheng-ledger hzheng-ledger requested a review from a team as a code owner September 13, 2024 07:03
@vercel Vercel
Copy link

vercel bot commented Sep 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 10:14am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 10:14am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 10:14am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 10:14am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 10:14am

@live-github-bot live-github-bot bot added common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Sep 13, 2024
hedi-edelbloute
hedi-edelbloute previously approved these changes Sep 13, 2024
View reviewed changes
libs/ledgerjs/packages/hw-app-polkadot/src/Polkadot.ts
const returnCode = errorCodeData[0] * 256 + errorCodeData[1];

if (returnCode === SW_CANCEL) {
throw new UserRefusedOnDevice();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this case still working ? (out of scope of this PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedi-edelbloute hedi-edelbloute hedi-edelbloute left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@hzheng-ledger hzheng-ledger

Labels
common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hzheng-ledger @hedi-edelbloute