Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coin-Fmk] Some clean-up #7801

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Conversation

sprohaszka-ledger
Copy link
Contributor

@sprohaszka-ledger sprohaszka-ledger commented Sep 12, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Remove unused derivation mode.
Enforce type with ModeSpec, instead of unknown.
Use typed version of @ledgerhq/live-network

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 12, 2024 9:07am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 9:07am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 9:07am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 9:07am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 9:07am

@live-github-bot live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label Sep 12, 2024
@sprohaszka-ledger sprohaszka-ledger marked this pull request as ready for review September 18, 2024 07:32
@Wozacosta
Copy link
Contributor

Just missing a changset.

@sprohaszka-ledger sprohaszka-ledger merged commit 1e6fba3 into develop Oct 4, 2024
55 checks passed
@sprohaszka-ledger sprohaszka-ledger deleted the support/simplify-coin-framework branch October 4, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants