Add PulseChain network

[bretep]

✅ Checklist

• npx changeset was attached.
• Covered by automatic tests.

📝 Description

Adds support for the PulseChain network.

Testing

I've tested this PR with LedgerHQ/app-ethereum#626 installed on:

• Ledger Stax
• Nano S Plus

Dependencies

This PR requires the changes introduced in LedgerHQ/app-ethereum#626.

---

🧐 Checklist for the PR Reviewers

• The code aligns with the requirements described in the linked JIRA or GitHub issue.
• The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
• There are no undocumented trade-offs, technical debt, or maintainability issues.
• The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
• Any new dependencies have been justified and documented.
• Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
web-tools	❌ Failed (Inspect)			Oct 30, 2024 1:26am

3 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
ledger-live-docs	⬜️ Ignored (Inspect)	Visit Preview		Oct 30, 2024 1:26am
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview		Oct 30, 2024 1:26am
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview		Oct 30, 2024 1:26am

[vercel]

Someone is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

[bretep]

I'm not able to see PulseChain app in the App catalog:

I have installed LedgerHQ/app-ethereum#626, and it seems to work correctly when viewing and signing messages.

Is there an additional step I need to take to add the PulseChain app, like the Binance Smart Chain (BNB) app?

[bretep]

I've tried to follow the published documentation and review patterns of the Polygon / Binance Smart Chain EVM networks.

Still unclear how to generate/sign the erc20 files, is this an internal process?

[bretep]

It's unclear to me how to update this with the erc20s to be added. Please advise. There are about 50 tokens to be added here.

[bretep]

I see that these files are all generated by importing the cryptoassets from CDN. Is there a bootstrapping process for an evm chain? We've got ~50 or so tokens to start off with. I've got a tokenlist that we can start from.

[bretep]

I was testing the flow by adding the PulseX token using the Ledger developer guide on integrating EVM chain tokens. Unfortunately, I found that PulseChain isn't listed yet, which means we'll need to get PulseChain integrated before tokens can be submitted for review.

[jnicoulaud-ledger]

Hi @bretep, thanks for your contribution :) Indeed, adding tokens list for new networks is an internal process, can you provide us with your list ?

[bretep]

I've created a zip file containing the default tokens in JSON/YAML format. There are 16 tokens in total.

• 11 tokens are mainnet tokens and contain the website and coingecko id.
• 5 tokens are for the testnet, which are worthless.

I've decided not to include the extended tokenlist and allow each project to go through your process of onboarding tokens. If you advise you would like the extended tokenlist, I will be happy to provide, but we do not have the coingecko id or website for those tokens.

If you prefer I paste the tokens in the issue, what format would you like them pasted in?

default_token_list.zip

[bretep]

Thank you! Please let me know if I need to do anything else.

[bretep]

@jnicoulaud-ledger, should I keep rebasing and force-pushing to keep up with the develop branch?

[jnicoulaud-ledger]

Hi, I pinged the relevant team to provide you with guidance on moving the PR forward

[bretep]

Awesome! Thank you!

[jnicoulaud-ledger]

The tokens have been added to our API:
https://crypto-assets-service.api.ledger.com/v1/tokens?network=pulsechain&output=id,name,ticker,contract_address
https://crypto-assets-service.api.ledger.com/v1/tokens?network=pulsechain_testnet&output=id,name,ticker,contract_address

[bretep]

@jnicoulaud-ledger I'm checking in to see the internal status of the PR. Is there something more I can do or another dev that can review this? Also, LedgerHQ/app-ethereum#626 needs review.

[lambertkevin]

Hi @bretep ! Thanks a lot for the PR !
So to answer your first comment, you won't be seeing a PulseChain app in the Catalog, as we've deprecated this method of creating what we called "clones" of the Ethereum app with hardcoded chain ids. Now everything is done using the Ethereum app as long as you're EVM compatible.

For everything else (appearing in Ledger Live portfolio, adding tokens etc...), unfortunately you'll need to go through a process with our product department in order to get an approval first and be integrated in our roadmap. Sorry for the heavy process, but with the quantity of new chains we have to integrate, it became mandatory for us not to implode internally 😞

Please join the Ledger Discord and ask about it there: https://discord.com/invite/ledger

[bretep]

Thank you, @lambertkevin, for the additional information. Yes, I think we're on the same page; using the Ethereum App, this is what it should look like. :)

I've been on Discord for some time now. Which channel and who should I reach out to? I've asked a couple of times on Discord but it seems like I'm not reaching the right people.

Thank you,

Bret

[bretep]

Just to note that I've reached out here on Discord: https://ptb.discord.com/channels/885256081289379850/907623688759803935/1283079422525706342

[lambertkevin]

Hi @bretep, the correct channel is: #blockchain-foundation

[github-actions]

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

[bretep]

Why was this closed?