Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

Sentry fixing iOS sourcemap #2463

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Sentry fixing iOS sourcemap #2463

wants to merge 3 commits into from

Conversation

gre
Copy link
Contributor

@gre gre commented Apr 29, 2022

  • Fix iOS sourcemap
    • test it with a staging build

@github-actions
Copy link

Thanks for your contribution.
To be able to merge in develop branch, you need to:

  • pass the CI
  • if needed, run /generate-screenshots
  • have a dev review
  • have a QA review
  • if needed, /upgrade-llc

Why /generate-screenshots ?

If your PR contains UI related changes,
it might be necessary to regenerate screenshots.

Why /upgrade-llc ?

If your PR requires an update to the ledger-live-common library,
once the PR is merged on develop on ledger-live-common side,
you need to run /upgrade-llc to switch back to ledger-live-common@develop here before merging.

@gre
Copy link
Contributor Author

gre commented May 10, 2022

I'm sending the exclusion part in #2500 because the sourcemap isn't fixed yet :'(

@gre gre force-pushed the bugfix/sentry-exclusion-2 branch from 34f76f5 to 5f68794 Compare May 12, 2022 12:58
@gre gre changed the title Sentry integration – iteration 2 Sentry fixing iOS sourcemap May 13, 2022
@gre gre force-pushed the bugfix/sentry-exclusion-2 branch from 5f68794 to b251394 Compare May 16, 2022 12:30
@gre gre force-pushed the bugfix/sentry-exclusion-2 branch from b251394 to d47f1a1 Compare May 16, 2022 12:57
@gre gre force-pushed the bugfix/sentry-exclusion-2 branch from 4178bfc to dd3fa67 Compare May 16, 2022 15:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant