Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

βœ… (tests) [NO-ISSUE]: Fix some remaining vitest tests #661

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

valpinkman
Copy link
Member

πŸ“ Description

A few forgotten test files to update

❓ Context

  • JIRA or GitHub link:
  • Feature:

βœ… Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@valpinkman valpinkman requested a review from a team as a code owner February 4, 2025 17:24
Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Feb 4, 2025 5:27pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
doc-device-management-kit ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 5:27pm

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Messages
⚠️ No changeset file found. Please make sure this is intended or add a changeset file.

Generated by 🚫 dangerJS against 77ba517

Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

200w (1)

@valpinkman valpinkman added this pull request to the merge queue Feb 4, 2025
Merged via the queue into develop with commit 7ac7181 Feb 4, 2025
12 checks passed
@valpinkman valpinkman deleted the chore/no-issue-vitest-update branch February 4, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants