Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (vitest) [NO-ISSUE]: Switch from jest to vitest #658

Merged
merged 10 commits into from
Feb 4, 2025

Conversation

valpinkman
Copy link
Member

@valpinkman valpinkman commented Feb 3, 2025

  • ✨ (dmk): Setup vitest on DMK
  • ✨ (client): Add vitest to flipper plugin + mockserver client
  • ✨ (signers): Vitest on signer-utils + context-module
  • ✨ (btc): Vitest setup to signer-btc
  • ✨ (eth): Vitest setup in signer-eth
  • ✨ (sol): Vitest setup to signer solana
  • ✨ (transports): Vitest setup to transports
  • ✨ (packages): Vitest setup to trusted-apps and ui packages

📝 Description

Switch test runner from jest to vitest

❓ Context

  • JIRA or GitHub link: [NO-ISSUE] DSDK-636
  • Feature:

✅ Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@valpinkman valpinkman requested a review from a team as a code owner February 3, 2025 17:00
Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 4:07pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
doc-device-management-kit ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 4:07pm

Copy link

socket-security bot commented Feb 3, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@types/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Messages
⚠️ No changeset file found. Please make sure this is intended or add a changeset file.

Generated by 🚫 dangerJS against a2075f4

Copy link
Contributor

@aussedatlo aussedatlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see an update on testDeviceActionStates.ts 🚀 , LGTM, we should try to merge this PR fast as it will bring a lot of conflicts otherwise

@valpinkman
Copy link
Member Author

Nice to see an update on testDeviceActionStates.ts 🚀 , LGTM, we should try to merge this PR fast as it will bring a lot of conflicts otherwise

yes i will do it today (i've rebased a few times and I agree)

@valpinkman valpinkman added this pull request to the merge queue Feb 4, 2025
Merged via the queue into develop with commit 2e6aa74 Feb 4, 2025
12 checks passed
@ofreyssinet-ledger
Copy link
Contributor

WebHIDTransport test also has a lot of done(error)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants