Add BIP-85 applications to Flex and Stax #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #14 +/- ##
===========================================
+ Coverage 60.04% 60.95% +0.90%
===========================================
Files 14 18 +4
Lines 1632 1670 +38
Branches 266 270 +4
===========================================
+ Hits 980 1018 +38
Misses 612 612
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| } | ||
| PRINTF("BIP85 index entered is '%d'\n", bip85_index_get()); | ||
|
|
||
| if ((bip85_index_get() >= 0) && (bip85_index_get() <= UINT32_MAX)) { |
Check warning
Code scanning / CodeQL
Unsigned comparison to zero Warning
| } | ||
| PRINTF("BIP85 index entered is '%d'\n", bip85_index_get()); | ||
|
|
||
| if ((bip85_index_get() >= 0) && (bip85_index_get() <= UINT32_MAX)) { |
Check warning
Code scanning / CodeQL
Comparison result is always the same Warning
aido
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following BIP-85 applications for Flex and Stax devices:
The code has also been written for other BIP-85 applications such as hex output and dice throws but a UI has not yet been added for these while I decide if they will be useful or just add bloat to the app. They may appear in a future version.
I am also debating what BIP-85 applications (if any) should be added to Nano devices.
This PR is currently a work in progress while I add some function tests.