Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] EIP-191 messages regression #660

Merged
merged 2 commits into from
Oct 3, 2024
Merged

[hotfix] EIP-191 messages regression #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c082950
Fix missing response APDU when continuing to review EIP-191 messages
apaillier-ledger Oct 2, 2024
64758c8
Bumped version number
apaillier-ledger Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [1.12.1](https://github.com/ledgerhq/app-ethereum/compare/1.12.0...1.12.1) - 2024-10-02

### Fixed

- Review of EIP-191 messages getting stuck and not responding to APDUs

## [1.12.0](https://github.com/ledgerhq/app-ethereum/compare/1.11.3...1.12.0) - 2024-09-27

### Added
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ include ./makefile_conf/chain/$(CHAIN).mk

APPVERSION_M = 1
APPVERSION_N = 12
APPVERSION_P = 0
APPVERSION_P = 1
APPVERSION = $(APPVERSION_M).$(APPVERSION_N).$(APPVERSION_P)

# Application source files
Expand Down
7 changes: 6 additions & 1 deletion src_features/signMessage/cmd_signMessage.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,13 @@ void skip_rest_of_message(void) {
* The user has decided to see the next chunk of the message
*/
void continue_displaying_message(void) {
uint16_t sw = APDU_RESPONSE_OK;

reset_ui_buffer();
if (unprocessed_length() > 0) {
feed_display();
sw = feed_display();
}
if (sw != APDU_NO_RESPONSE) {
io_seproxyhal_send_status(sw, 0, sw != APDU_RESPONSE_OK, sw != APDU_RESPONSE_OK);
}
}
Loading