Fix EIP-712 NBGL pairs packing #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaillier-ledger
force-pushed
the
fix/apa/eip712_pairs_packing_with_skip
branch
from
f79c1c5
to
a02bbe7
Compare
apaillier-ledger
force-pushed
the
fix/apa/eip712_pairs_packing_with_skip
branch
from
892a4dd
to
cee9edd
Compare
cedelavergne-ledger
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses LedgerHQ/ledger-secure-sdk#787
Snapshots had to be re-generated because of an SDK bump for Stax & Flex in the app-builder, not because of this one-line change.
Changes include