Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved EIP-712 error handling #636

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Improved EIP-712 error handling #636

merged 2 commits into from
Sep 4, 2024

Conversation

apaillier-ledger
Copy link
Contributor

Description

Non-sensical type definitions could make the EIP-712 type_hash function crash.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@apaillier-ledger apaillier-ledger marked this pull request as ready for review September 2, 2024 15:11
@apaillier-ledger apaillier-ledger merged commit 21d6e31 into develop Sep 4, 2024
156 checks passed
@apaillier-ledger apaillier-ledger deleted the fix/apa/eip712_error_handling branch September 4, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedelavergne-ledger cedelavergne-ledger cedelavergne-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apaillier-ledger @cedelavergne-ledger