Fix EIP-712 filtering on empty array #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaillier-ledger
force-pushed
the
fix/apa/filtering_on_empty_array
branch
from
f8d9ee4
to
5d99c62
Compare
apaillier-ledger
force-pushed
the
fix/apa/filtering_on_empty_array
branch
2 times, most recently
from
b6eb314
to
7242a92
Compare
apaillier-ledger
force-pushed
the
fix/apa/filtering_on_empty_array
branch
from
7242a92
to
ab94ac8
Compare
cedelavergne-ledger
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For filters targeting fields within an array that turned out to be empty, the app would never receive these fields implementation (because they don't exist), same for their corresponding filters, so the app would at the end of the review flow complain about missing filters.
Changes include