B2CA-1272: Remove throw from App #578

cedelavergne-ledger · 2024-04-30T09:20:39Z

Cleanup the full App:

Use full standard app (except main.c, which is dedicated because too different from SDK)
Cleanup APDU_RESPONSE_xx code and remove hardcoded values in the source code
Replace the THROW by return codes
Replace most LEDGER_ASSERT and CX_ASSERT by return codes
Improve and factorize io_seproxyhal_xxx functions
Fix duplicated header filenames between sdk and app
Fix #B2CA-1583 (App blocked after unplug usb when rejecting a transaction)
Cleanup main.c

Changes include

Bugfix (non-breaking change that solves an issue)
New feature (non-breaking change that adds functionality)
Breaking change (change that is not backwards-compatible and/or changes current functionality)
Tests
Documentation
Other (for changes that might not fit in any category)

src/main.c

- Use SDK function apdu_parser - Replace THROW by return code (1st step) - Cleanup BEGIN_TRY - Factorize storage_init code

…tion

github-advanced-security bot found potential problems Apr 30, 2024

View reviewed changes

src/main.c Fixed Show fixed Hide fixed

cedelavergne-ledger force-pushed the cev/B2CA-1272_remove-THROW branch 2 times, most recently from 38cfe01 to 912fc3d Compare April 30, 2024 10:03

cedelavergne-ledger force-pushed the cev/B2CA-1272_remove-THROW branch 2 times, most recently from 59de1ea to dc6b3ec Compare August 1, 2024 15:43

github-advanced-security bot found potential problems Aug 1, 2024

View reviewed changes

src/main.c Fixed Show fixed Hide fixed

cedelavergne-ledger force-pushed the cev/B2CA-1272_remove-THROW branch 3 times, most recently from c1e202a to e92d72c Compare August 6, 2024 13:38

github-advanced-security bot found potential problems Aug 6, 2024

View reviewed changes

src/main.c Fixed Show fixed Hide fixed

cedelavergne-ledger force-pushed the cev/B2CA-1272_remove-THROW branch 6 times, most recently from cb3b654 to 8e8850d Compare August 7, 2024 15:30

github-advanced-security bot found potential problems Aug 7, 2024

View reviewed changes

src/main.c Fixed Show fixed Hide fixed

cedelavergne-ledger force-pushed the cev/B2CA-1272_remove-THROW branch 12 times, most recently from 5066346 to 55c058f Compare August 9, 2024 12:52

github-advanced-security bot found potential problems Aug 9, 2024

View reviewed changes

src/main.c Dismissed Show dismissed Hide dismissed

cedelavergne-ledger added 24 commits August 30, 2024 17:58

Cleanup main.c

2970142

- Use SDK function apdu_parser - Replace THROW by return code (1st step) - Cleanup BEGIN_TRY - Factorize storage_init code

Fix return code in 'get_challenge'

2e54116

Fix return code in 'handle_provide_domain_name'

896ce56

Fix return code in 'handleGetEth2PublicKey'

97f623e

Fix return code in 'handleSetEth2WithdrawalIndex'

7ea71c5

Fix return code in 'handleGetPublicKey'

cb46e39

Fix return code in 'handleProvideErc20TokenInformation'

95d393d

Fix return code in 'handleGetAppConfiguration'

898dd18

Fix return code in 'handleProvideNFTInformation'

4bbc1ee

Fix return code in 'handleSetExternalPlugin'

a65c2da

Fix return code in 'handleSetPlugin'

94b224f

Fix return code in 'handlePerformPrivacyOperation'

36247f2

Fix return code in 'handleSign'

0596b82

Fix return code in 'handleSignPersonalMessage'

5950c78

Fix return code in 'handleSignEIP712Message_v0'

0ca8920

Fix return code in 'handle_eip712_xxx'

4a1614d

Fix THROW in eip191

178fb89

Fix THROW in eip712

08262c7

Fix THROW in src_plugins

dffa174

Replace most LEDGER_ASSERT and CX_ASSERT

d39ba75

Finalize cleanup main.c

24633f2

Fix B2CA-1583 - App blocked after unplug usb when rejecting a transac…

154eb42

…tion

Fix missing destination directory in tool 'copy_clones.sh'

2af8315

Update ethereum-plugin-sdk

528e768

cedelavergne-ledger force-pushed the cev/B2CA-1272_remove-THROW branch from b366824 to 528e768 Compare August 30, 2024 15:58

apaillier-ledger approved these changes Aug 30, 2024

View reviewed changes

cedelavergne-ledger merged commit 25cda9a into develop Aug 30, 2024
156 checks passed

cedelavergne-ledger deleted the cev/B2CA-1272_remove-THROW branch August 30, 2024 16:08

cedelavergne-ledger mentioned this pull request Sep 6, 2024

Make clearer error code #161

Closed

apaillier-ledger mentioned this pull request Oct 2, 2024

[hotfix] EIP-191 messages regression #660

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

B2CA-1272: Remove throw from App #578

B2CA-1272: Remove throw from App #578

cedelavergne-ledger commented Apr 30, 2024 •

edited

Loading

B2CA-1272: Remove throw from App #578

B2CA-1272: Remove throw from App #578

Conversation

cedelavergne-ledger commented Apr 30, 2024 • edited Loading

Changes include

cedelavergne-ledger commented Apr 30, 2024 •

edited

Loading