Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B2CA-1522: Add sender field in transaction #545

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

cedelavergne-ledger
Copy link
Contributor

@cedelavergne-ledger cedelavergne-ledger commented Mar 11, 2024

In addition to the To field, add the From to ease the transaction addresses reviews

Description

Add new field in the structure
Add new field in the ValuePair review information
Update tests and screenshots

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@ledger-wiz-cspm-secret-detection
Copy link

ledger-wiz-cspm-secret-detection bot commented Mar 14, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 0H 0M 0L 0I
Total 0C 0H 0M 0L 0I
Secrets 0🔑

src/shared_context.h Outdated Show resolved Hide resolved
@apaillier-ledger apaillier-ledger self-requested a review June 20, 2024 08:06
@cedelavergne-ledger cedelavergne-ledger merged commit 6d6f7c7 into develop Jun 20, 2024
151 checks passed
@cedelavergne-ledger cedelavergne-ledger deleted the cev/add_sender_field branch June 20, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants