Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stax UI fixes #440

Merged
merged 12 commits into from
Jul 18, 2023
Merged

Stax UI fixes #440

merged 12 commits into from
Jul 18, 2023

Conversation

apaillier-ledger
Copy link
Contributor

Description

  • Fixes some minor issues on the NBGL UI of the app.
  • Small refactoring of the message signing NBGL code

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

fbeutin-ledger
fbeutin-ledger reviewed Jun 27, 2023
View reviewed changes
Copy link
Contributor

@fbeutin-ledger fbeutin-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part 1, let's agree on the first batch and I'll finish ! :)

src_nbgl/ui_approve_tx.c Outdated Show resolved Hide resolved
src_nbgl/ui_message_signing.c Outdated Show resolved Hide resolved
src_nbgl/ui_approve_tx.c Show resolved Hide resolved
src_nbgl/ui_approve_tx.c Outdated Show resolved Hide resolved
src_nbgl/ui_approve_tx.c Outdated Show resolved Hide resolved
src_nbgl/ui_confirm_parameter_selector.c Outdated Show resolved Hide resolved
src_nbgl/ui_sign_message.c Outdated Show resolved Hide resolved
src_nbgl/ui_sign_message.c Outdated Show resolved Hide resolved
src_nbgl/ui_signing.h Show resolved Hide resolved
src_nbgl/ui_signing.h Show resolved Hide resolved
@apaillier-ledger apaillier-ledger force-pushed the fix/apa/stax_ui_changes branch 3 times, most recently from 2579eea to 7180d67 Compare June 29, 2023 12:44
@apaillier-ledger apaillier-ledger merged commit f0df04a into develop Jul 18, 2023
@apaillier-ledger apaillier-ledger deleted the fix/apa/stax_ui_changes branch July 18, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbeutin-ledger fbeutin-ledger fbeutin-ledger approved these changes

Assignees

@apaillier-ledger apaillier-ledger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apaillier-ledger @fbeutin-ledger