Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI enhancements #23

Merged
merged 9 commits into from
Nov 27, 2024
Merged

UI enhancements #23

merged 9 commits into from
Nov 27, 2024

Conversation

kingofpayne
Copy link
Contributor

No description provided.

Copy link
Member

@mmouchous-ledger mmouchous-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for changes, some extra things to do:

  • make the cursor position to have fixed size
  • add "label" in configuration scheme

Copy link
Member

@mmouchous-ledger mmouchous-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the changes and additional UI Enhancement, could you please confirm before explicit approval?

  • Viewer's mode (PIN / MOVE / ZONE) selection is unset when button is pressed again (should we also do the same behavior with shortcuts?)
  • config.yaml file has the "label" field is attached to any "instrument" object (probe, camera, laser, ...)
  • Zoom toolbars's label indicating cursor position is monospaced and have fixed width

@kingofpayne
Copy link
Contributor Author

should we also do the same behavior with shortcuts?
I would say no, otherwise the user may disable using the shortcut while believing it is enabling it.

@mmouchous-ledger mmouchous-ledger self-assigned this Nov 27, 2024
@mmouchous-ledger mmouchous-ledger self-requested a review November 27, 2024 17:10
@mmouchous-ledger mmouchous-ledger merged commit 976d755 into main Nov 27, 2024
2 checks passed
@kingofpayne kingofpayne deleted the ui-enhancements branch November 28, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants