Skip to content

Commit

Permalink
More comments in Dockerfile
Browse files Browse the repository at this point in the history
Signed-off-by: Benoit Donneaux <[email protected]>
  • Loading branch information
btlogy committed Jan 31, 2024
1 parent 366e511 commit 2c9e1f5
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
8 changes: 8 additions & 0 deletions client-e2e/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,10 +1,18 @@
FROM node:16-alpine

# Switch to the directory where the client code will live
WORKDIR /usr/src/app/client-e2e


# Install the required packages... But not really?
# FIXME: do it or get rid of this block
COPY package.json .
COPY package-lock.json .
#RUN npm install

# Copy the whole context except what is explicitly ignored
# TODO: be explicit instead?
COPY . .

# Start the dev server by default
CMD ["npm", "run", "wdio"]
3 changes: 2 additions & 1 deletion client/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ COPY package.json .
COPY package-lock.json .
RUN npm install --location=global --unsafe-perm

# Copy the whole context except what is explicitely ignored
# Copy the whole context except what is explicitly ignored
# TODO: be explicit instead?
COPY . .

# Install the required pages again, but localy this time
Expand Down

0 comments on commit 2c9e1f5

Please sign in to comment.