Passing the label context to regional module #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the last change I did not add passing the label context to the regional module which causes the IAM role to have a name of -iam_for_lambda rather than adding the further context to make sure it is unique per environment.
|
Once this is merged it would be useful if there was another release of the module so I could move back to using the Terraform registry. Happy to help out maintaining this Terraform module. |
cristim
approved these changes
Jul 15, 2020
|
Released 0.1.6 with the latest code changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last change I did not add passing the
label context to the regional module which
causes the IAM role to have a name of
-iam_for_lambda rather than adding the further
context to make sure it is unique per
environment.