Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Introducing Trade #32

Merged
merged 38 commits into from
Oct 5, 2024
Merged

✨ Introducing Trade #32

merged 38 commits into from
Oct 5, 2024

Conversation

YousefEZ
Copy link
Member

@YousefEZ YousefEZ commented Sep 1, 2024

πŸ“‹ Todo:

  • Refactor out nation lookup
  • Add Trade API
  • Add Trade UI
  • Add Tests for Trade API

This was linked to issues Sep 1, 2024
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 19.21397% with 185 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@45ce3fd). Learn more about missing BASE report.

Files with missing lines Patch % Lines
view/cogs/trade.py 0.00% 73 Missing ⚠️
lon.py 0.00% 50 Missing ⚠️
host/nation/trade.py 46.96% 35 Missing ⚠️
view/cogs/aid.py 0.00% 19 Missing ⚠️
view/cogs/start.py 0.00% 6 Missing ⚠️
view/cogs/custom_jinja2.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage        ?   53.07%           
=======================================
  Files           ?       42           
  Lines           ?     2374           
  Branches        ?        0           
=======================================
  Hits            ?     1260           
  Misses          ?     1114           
  Partials        ?        0           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@YousefEZ YousefEZ merged commit 78ec4d6 into main Oct 5, 2024
2 of 3 checks passed
@YousefEZ YousefEZ deleted the trade branch October 5, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Trade Transactions ✨ Trade UI
1 participant