Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos in nits article #241

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Typos in nits article #241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions content/blog/tyranny-of-nits/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ Open source projects tend to run on **naive consensus by default.**
The operating semantics are simple:

1. If everyone says "LGTM", the work gets merged.
2. If someone reasis a concern, we wait for the author to fix it.
2. If someone raises a concern, we wait for the author to fix it.
3. If the author doesn't fix the concern, the PR stays open (or gets closed as stale).
4. If the author comes back and says "that's not a problem actually", then we get orgnizational undefined behavior.

Expand Down Expand Up @@ -100,7 +100,7 @@ But just as importantly: invest in paying off your tech debt and clarifying your
If it's *obvious* how to do something, you won't have to waste everyone's time explaining that someone did something the wrong way.
Get those eager new contributors to help, seriously.

On the other hand, you could try to reduce the maount of nits that are picked.
On the other hand, you could try to reduce the amount of nits that are picked.
I don't actually think that telling reviewers "don't worry about this stuff" is generally a useful strategy: it tends to breed resentment and makes them stay quiet on helpful low-cost improvements.
Instead, get them to focus on splitting apart their "would be nice" feedback from "this must be fixed" feedback.

Expand Down